Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLD-6659] Add documentation for Cloud IP Filtering #6792

Merged
merged 22 commits into from
Jan 16, 2024
Merged

Conversation

nickmisasi
Copy link
Contributor

Comment on lines 19 to 28
Understanding CIDR Notation:
----------------------------


CIDR (Classless Inter-Domain Routing) notation is used to specify a range of IP addresses. It consists of an IP address followed by a forward slash and a number indicating the network's prefix length. For example:

- `192.168.0.0/24` represents the IP range from `192.168.0.0` to `192.168.0.255`.
- The `/24` signifies that the first 24 bits are the network address, leaving 8 bits for host addresses.

For a more in-depth explanation of CIDR notation, refer to `this article </https://aws.amazon.com/what-is/cidr/>`__.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is inherently technical in that it requires knowledge of CIDR notation. I tried to hit an even ground of explanation without rewriting wikipedia. Generally, if you don't know what CIDR notation is, you probably aren't the intended audience for this feature

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very fair assumption to make. Mattermost product documentation focuses on Mattermost-centric details and points readers to external, third-party sources where appropriate. Nicely done.

Copy link

Newest code from nickmisasi has been published to preview environment for Git SHA 6993fb7

@nickmisasi nickmisasi added 1: Dev Review Requires review by a core commiter 1: PM Review Requires review by a product manager 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Nov 15, 2023
@nickmisasi
Copy link
Contributor Author

Link to the specific page I've added in the preview environment: http://mattermost-docs-preview-pulls.s3-website-us-east-1.amazonaws.com/6792/manage/cloud-ip-filtering.html

Copy link

Newest code from nickmisasi has been published to preview environment for Git SHA 6993fb7

3 similar comments
Copy link

Newest code from nickmisasi has been published to preview environment for Git SHA 6993fb7

Copy link

Newest code from nickmisasi has been published to preview environment for Git SHA 6993fb7

Copy link

Newest code from nickmisasi has been published to preview environment for Git SHA 6993fb7

Copy link

github-actions bot commented Dec 4, 2023

Newest code from cwarnermm has been published to preview environment for Git SHA a60d77e

1 similar comment
Copy link

github-actions bot commented Dec 4, 2023

Newest code from cwarnermm has been published to preview environment for Git SHA a60d77e

Copy link

github-actions bot commented Dec 5, 2023

Newest code from cwarnermm has been published to preview environment for Git SHA 9108976

@cwarnermm cwarnermm added this to the v9.3.0 milestone Dec 5, 2023
@cwarnermm cwarnermm removed the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Dec 7, 2023
@cwarnermm
Copy link
Member

@amyblais - This is a v9.3 documentation update that's ready for release.

Copy link

github-actions bot commented Dec 7, 2023

Newest code from cwarnermm has been published to preview environment for Git SHA a9bdf5d

@amyblais
Copy link
Member

amyblais commented Dec 7, 2023

This is a v9.3 documentation update that's ready for release.

Thank you, I believe the IP Filtering feature itself is scheduled for v9.4.

@cwarnermm cwarnermm removed this from the v9.3.0 milestone Dec 7, 2023
@nab-77
Copy link
Contributor

nab-77 commented Dec 7, 2023

Superb update.

@cwarnermm cwarnermm added this to the v9.4.0 milestone Dec 8, 2023
@cwarnermm cwarnermm added the Do Not Merge/Awaiting Next Release To be merged with the next release (e.g. API documentation updates) label Dec 8, 2023
@nickmisasi nickmisasi self-assigned this Dec 11, 2023
Copy link

Newest code from nickmisasi has been published to preview environment for Git SHA a9bdf5d


IP filtering is a powerful security feature that allows system admins to control access to their workspace by defining approved IP ranges. Only users within these specified IP ranges can access the workspace, ensuring enhanced security for your workspace. IP filtering requires a subscription to Mattermost Cloud Enterprise.

Configure IP filtering
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickmisasi - Based on the v9.4 server changelog, Cloud IP Filtering will be disabled OOTB behind a feature flag.

Are you open to updating this new docs page to include details on enabling the feature flag as an admin?

Copy link
Contributor Author

@nickmisasi nickmisasi Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End users (ie, anyone not on the Mattermost Cloud team) can't control feature flags in Cloud. The feature flag's in place so that we can wait until other system dependencies (CWS, Provisioner, etc) are ready without having to hold up the 9.4 release. An additional benefit is that we can disable the new feature in the event a glaring issue is found after release.

I'm not sure it's worth documenting this as it's invisible to the user and may just cause confusion. Let me know what you think!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to add - the plan would be to enable the feature flag immediately as soon as the release rolls out to the enterprise ring in Cloud

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right -- users can't enable feature flags in Cloud. I'd forgotten that important point. No sense documenting something that Cloud admins won't be able to do.

Given that the plan is to enable soon after release to the Enterprise ring, I wonder if the changelog needs a small update to clarify that point? Thoughts?

Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 2213b41

Copy link

Newest code from stafot has been published to preview environment for Git SHA aff94e4

Copy link

github-actions bot commented Jan 8, 2024

Newest code from cwarnermm has been published to preview environment for Git SHA 5f2ea81

Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 3e49ef1

@amyblais amyblais removed the Do Not Merge/Awaiting Next Release To be merged with the next release (e.g. API documentation updates) label Jan 16, 2024
Copy link

Newest code from amyblais has been published to preview environment for Git SHA 8cb2b1d

@amyblais amyblais merged commit d946ab3 into master Jan 16, 2024
4 checks passed
@amyblais amyblais deleted the ip-filtering-docs branch January 16, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants